RFR: 2089: Warn when bug fixVersion doesn't match .jcheck/conf version in PR

Kevin Rushforth kcr at openjdk.org
Wed Nov 8 23:36:04 UTC 2023


On Wed, 8 Nov 2023 22:46:19 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch tries to alert the user when the fixVersion in the issue differs from the fixVersion in .jcheck/conf, thereby preventing the creation of unwanted backports.

There are valid cases where this could occur, so it might generate a bit of noise.

I have a few questions:
* Does this correctly handle a fix version of "tbd", or "NN-pool" or come other "pseudo" version? Those should be considered matching. 
* When you say ".jcheck/conf" version, what about repos that are configured to use a fix version from the Skara configuration?

I think the main case you want to handle are in repos (e.g., mainline jdk) where the `.jcheck/conf` version is used, and has a value of NN and the JBS mainline fix version has a concrete value of "MM". Anything else seems likely to generate more noise than be hepful.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1585#issuecomment-1802900310


More information about the skara-dev mailing list