RFR: 2089: Warn when bug fixVersion doesn't match .jcheck/conf version in PR

[Erik Joelsson]

On Wed, 8 Nov 2023 23:33:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> I have a few questions:
> 
> * Does this correctly handle a fix version of "tbd", or "NN-pool" or come other "pseudo" version? Those should be considered matching.

Yes, it's calling the same logic as the Notifier uses to find an existing backport record. If it finds a match, no warning is printed. If the main bug is not open, no warning is printed. I think this is doing what we want.

> * When you say ".jcheck/conf" version, what about repos that are configured to use a fix version from the Skara configuration?

The Skara configuration for fixVersion is only present in the notifier bot, so the PR bot doesn't know (unless we add this configuration option, which would be awkward to maintain for the admin). The logic here will only try to look for a mismatch if the fixVersion can be found through .jcheck/conf. This means that if a repo has a .jcheck/conf with a version defined, and we configure the Notifier with a different fixVersion, then this warning will be printed when it shouldn't be. We need some kind of configuration to prevent this. Another boolean flag in the configuration for PR bot.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1585#issuecomment-1802978896