RFR: 2049: After enabled maintainer approval in a repo, some pull requests are not updated [v2]

Zhao Song zsong at openjdk.org
Tue Oct 3 16:00:26 UTC 2023


On Tue, 3 Oct 2023 08:47:44 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
>>   
>>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 217:
> 
>> 215:                         }
>> 216:                         if (bot.approval() != null && bot.approval().needsApproval(pr.targetRef())) {
>> 217:                             // Add a static sting to the metadata if the PR needs approval to force
> 
> Typo: `string` instead of `sting`?

Thanks! I will fix it later.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1563#discussion_r1344346997


More information about the skara-dev mailing list