RFR: 2061: Checking for .jcheck/conf fails when pr/X branches are removed [v2]

Zhao Song zsong at openjdk.org
Thu Oct 12 15:53:19 UTC 2023


> As Erik described in the issue, "The targetRefPRMap introduced in [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937) isn't working well with the dependent PR feature. When a pr/X branch is removed, the map may still contains that branch which will cause getPeriodicItems to fail with exception when trying to get .jcheck/conf from the non existing branch.". 
> 
> To solve this issue, I think that every pr would only have one targetRef, so before the bot is trying to create an entry for the pr, the bot should delete any existing entry associated with that pr.
> 
> Since the operations are all about HashMap, I believe they wouldn't significantly impact the bot's performance.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1568/files
  - new: https://git.openjdk.org/skara/pull/1568/files/785adc64..d4f55dbb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1568&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1568&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1568.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1568/head:pull/1568

PR: https://git.openjdk.org/skara/pull/1568


More information about the skara-dev mailing list