RFR: 2061: Checking for .jcheck/conf fails when pr/X branches are removed [v2]

Zhao Song zsong at openjdk.org
Thu Oct 12 15:53:20 UTC 2023


On Thu, 12 Oct 2023 14:54:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java line 185:
> 
>> 183:                 var prId = pr.id();
>> 184:                 if (pr.isOpen()) {
>> 185:                     targetRefPRMap.keySet().forEach(key -> targetRefPRMap.get(key).remove(prId));
> 
> I think this could be simplified by just iterating over `targetRefPRMap.values()`.

Yes, it should be better.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1568#discussion_r1357027926


More information about the skara-dev mailing list