RFR: build: use included build instead of buildSrc

Andrei Rybak duke at openjdk.org
Thu Sep 14 09:38:48 UTC 2023

On Wed, 10 Feb 2021 10:44:44 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that makes the build use "included builds" for Skara's Gradle plugins instead of the "buildSrc" feature of Gradle. The "buildSrc" feature doesn't play nice with Gradle's caching mechanism - any change to a file in the `buildSrc` directory invalidates the build cache. The solution is to just include the plugins using the `includeBuild` feature (the Gradle team is even thinking of making `buildSrc` an implicitly included build, see https://github.com/gradle/gradle/issues/2531).
> Testing:
> - [x] `make images` on Linux x64
> - [x] `make test` on Linux x64
> Thanks,
> Erik

build.gradle line 1:

> 1: /*

I've stumbled upon an outdated reference to `buildSrc` in the root `build.gradle`:

        // Force Gradle to load the JUnit Platform Launcher from the module-path, as
        // configured in buildSrc/.../ModulePlugin.java -- see SKARA-69 for details.
        testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.6.2'



PR Review Comment: https://git.openjdk.org/skara/pull/1004#discussion_r1325680367

More information about the skara-dev mailing list