Distinguish changes that require review in personal pull request overview

[Lindenmaier, Goetz]

Hi,

I opened an issue: [SKARA-2032] Distinguish changes that require review in personal pull request overview - Java Bug System (openjdk.org)<https://bugs.openjdk.org/browse/SKARA-2032>

Thanks for considering this!
Best regards,
  Goetz.

From: erik.joelsson at oracle.com <erik.joelsson at oracle.com>
Sent: Tuesday, September 19, 2023 3:27 PM
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; skara-dev at openjdk.org
Subject: Re: Distinguish changes that require review in personal pull request overview


Hello Goetz,

I think this suggestion makes sense. Before support for the approval process, then the "ready" label more or less corresponded to a reviewed PR, but since we now have multiple steps to pass before a PR is ready, there isn't a clear label indication for each step. Perhaps we should adopt a general pattern of adding a label for each progress step as they get fulfilled (e.g. "reviewed", "approved")? Changing color of a label probably won't work. I think the colors are configured on a repo level. Also you can't filter on a label color.

Could you file this request as an enhancement?

/Erik
On 9/19/23 00:56, Lindenmaier, Goetz wrote:
Hi,

I have a proposal for a small improvement of
productivity:

I am using github.com/pulls as worklist for my daily todos.
With the new added “approval” label I now can see
in this list for which pull requests I requested approval, and, with
the “ready” label, whether I got the approval.

What I can not distinguish are changes that require
a review and those that got a review.  In both cases
there is the red “rfr” label.  Thus, I daily open all the
pull requests and check whether they got a review.

Is it possible to add a label that indicates that a pull
request has been reviewed as required?
Maybe the “rfr” label could be changed in colour
(grey?) once there is a sufficient amount of reviews?

Then I can see in the list which pull request are
ready for the approval request.
Or did a miss something and this is already possible?

Best regards,
  Goetz.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/skara-dev/attachments/20230920/33c1b01a/attachment.htm>