Suggestion regarding Skara /approval command

erik.joelsson at oracle.com erik.joelsson at oracle.com
Fri Sep 22 13:08:35 UTC 2023


Hello,

If you as maintainers would prefer it that way, we can certainly change 
it. I wasn't sure which way to go with that. My assumption was that it 
would encourage people to be lazy and just add the same text to multiple 
bugs, when each of them were likely to require individual motivations.

Note that for the maintainer, the /approve command already approves all 
associated bugs if no bugid is given.

/Erik

On 9/22/23 05:13, Kevin Rushforth wrote:
> +1 for this suggestion.
>
> -- Kevin
>
> On 9/22/2023 1:01 AM, Lindenmaier, Goetz wrote:
>>
>> Hi,
>>
>> I had thought about the same issue.
>>
>> /approval all request
>>
>> would be another nice solution to this.
>>
>> And similarly /approve all yes.
>>
>> Best regards,
>>
>> Goetz.
>>
>> *From:*skara-dev <skara-dev-retn at openjdk.org> *On Behalf Of *Langer, 
>> Christoph
>> *Sent:* Friday, September 22, 2023 9:58 AM
>> *To:* skara-dev at openjdk.org
>> *Subject:* Suggestion regarding Skara /approval command
>>
>> Hi,
>>
>> I have a small suggestion for the great new approval feature in Skara.
>>
>> Currently, when a PR refers to multiple JBS issues, I have to request 
>> approval for each of them with a distinct “/approval request 
>> JDK-<nnn>” command. However, since the approval text that I’d add to 
>> each of the items in such a case would often be the same, I’d like to 
>> suggest that in such cases an “/approval request” without bug ids 
>> adds the label and text to all of the referred bugs. Do you think 
>> this makes sense? If yes, I can create an issue for that.
>>
>> Thanks
>>
>> Christoph
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/skara-dev/attachments/20230922/228faa76/attachment-0001.htm>


More information about the skara-dev mailing list