RFR: 2037: Change the order of bots in PullRequestBotFactory [v2]

Zhao Song zsong at openjdk.org
Fri Sep 22 17:01:08 UTC 2023


> Today, when restarting the bot, I found that the IssueBot was down for a long time(about 30 minutes), and then I realized that in PullRequestBotFactory, we created all pullRequestBots first, then CSRIssueBots, and IssueBots last. 
> 
> After the bot is restarted, the botRunner would run all pullRequestBots first and we have a lot of pullRequestBots, so it will take a lot of time. And if users make changes to issues in JBS during this interval, the IssueBot may not be able to get all updated issues. It's really bad. 
> 
> To solve this problem, we could to reverse the order of bots in PullRequestBotFactory, therefore we could make sure IssueBot will be run firstly.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1558/files
  - new: https://git.openjdk.org/skara/pull/1558/files/97ce00d1..65f93747

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1558&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1558&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1558.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1558/head:pull/1558

PR: https://git.openjdk.org/skara/pull/1558


More information about the skara-dev mailing list