RFR: 2037: Change the order of bots in PullRequestBotFactory [v2]

Erik Joelsson erikj at openjdk.org
Fri Sep 22 17:51:32 UTC 2023

On Fri, 22 Sep 2023 17:01:08 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Today, when restarting the bot, I found that the IssueBot was down for a long time(about 30 minutes), and then I realized that in PullRequestBotFactory, we created all pullRequestBots first, then CSRIssueBots, and IssueBots last. 
>> After the bot is restarted, the botRunner would run all pullRequestBots first and we have a lot of pullRequestBots, so it will take a lot of time. And if users make changes to issues in JBS during this interval, the IssueBot may not be able to get all updated issues. It's really bad. 
>> To solve this problem, we could to reverse the order of bots in PullRequestBotFactory, therefore we could make sure IssueBot will be run firstly.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   review comment

Marked as reviewed by erikj (Lead).


PR Review: https://git.openjdk.org/skara/pull/1558#pullrequestreview-1640411103

More information about the skara-dev mailing list