RFR: 2049: After enabled maintainer approval in a repo, some pull requests are not updated

Erik Joelsson erikj at openjdk.org
Thu Sep 28 18:40:22 UTC 2023

On Thu, 28 Sep 2023 17:58:34 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Today, I enabled maintainer approval feature in openjdk/jdk8u-dev. 
> After I enabled this feature, I expect to see the progress like "JDK-XXXXXXX needs maintainer approval" in the body of all open prs. 
> However, this pr(https://github.com/openjdk/jdk8u-dev/pull/368) is not updated. 
> The reason is that although after we enabled the maintainer approval feature, the issue labels will be calculated in the issueMetaData, there still exists some issues that doesn't contain any label. 
> To solve this, I think we could add a string "approval" to issueMetaData after we enabled the maintainer approval.

Looks good, but I would like a comment explaining why. Added suggestion.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 217:

> 215:                         }
> 216:                         if (bot.approval() != null && bot.approval().needsApproval(pr.targetRef())) {
> 217:                             issueData.append("approval");


                            // Add a static sting to the metadata if the PR needs approval to force
                            // update if this configuration has changed for the target branch.


PR Review: https://git.openjdk.org/skara/pull/1563#pullrequestreview-1649498164
PR Review Comment: https://git.openjdk.org/skara/pull/1563#discussion_r1340539063

More information about the skara-dev mailing list