RFR: 2331: Improve review notes [v3]

[Erik Joelsson]

On Tue, 6 Aug 2024 13:55:11 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Sorry for the delay.
>> 
>> For the (now largely unused) case of `useStaleReviews=true`, I would expect no change from today's behavior: Regardless of whether or not the review criteria is met, print "⚠️ Review applies to HASH" for all stale reviews.
>> 
>> For the (now widely-used) case of `useStaleReviews=false`: If the review criteria is _not_ met, print "🔄 Re-review required (review applies to HASH)" for all stale reviews; if the review criteria _is_ met, print "Review applies to HASH" with no emoji for all stale reviews.
>
> To further clarify, the algorithm you propose applies to the usual case where some commits have been added on top of those reviewed; and not to the more rare cases, where either the reviewed commit is no longer present or the PR has changed its target branch. Is that correct?

I'm ok with Kevin's proposed behavior, but I'm not sure what the significance of your last question is, Pavel. Are we behaving differently today when the commit has gone missing or the branch has changed?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1679#discussion_r1712145741