RFR: 2418: Scratch dir clash in notifier

Zhao Song zsong at openjdk.org
Tue Dec 3 19:37:17 UTC 2024


On Tue, 3 Dec 2024 18:42:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The notifier RepositoryWorkItem and PullRequestWorkItem have a clash between directory location for the history repos. In RepositoryWorkItem we store the tags and branches history in these directories:
> 
> 
> <scratch>/notify/history/tags
> <scratch>/notify/history/branches
> 
> 
> While in the PullRequestWorkItem, the history is stored in:
> 
> 
> <scratch>/notify/history
> 
> 
> Having repositories nested inside each other like this is causing inefficiencies at the very least, but could also potentially be harmful. As a quick fix, I propose we move the pr history to
> 
>  ```
>  <scratch>/notify/history/pr
>  ```

LGTM

-------------

Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1700#pullrequestreview-2476618869


More information about the skara-dev mailing list