Integrated: 2418: Scratch dir clash in notifier

Erik Joelsson erikj at openjdk.org
Tue Dec 3 21:13:54 UTC 2024


On Tue, 3 Dec 2024 18:42:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The notifier RepositoryWorkItem and PullRequestWorkItem have a clash between directory location for the history repos. In RepositoryWorkItem we store the tags and branches history in these directories:
> 
> 
> <scratch>/notify/history/tags
> <scratch>/notify/history/branches
> 
> 
> While in the PullRequestWorkItem, the history is stored in:
> 
> 
> <scratch>/notify/history
> 
> 
> Having repositories nested inside each other like this is causing inefficiencies at the very least, but could also potentially be harmful. As a quick fix, I propose we move the pr history to
> 
>  ```
>  <scratch>/notify/history/pr
>  ```

This pull request has now been integrated.

Changeset: 49dd2200
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/49dd2200dc96c387a373caef2b3535f2da54f531
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

2418: Scratch dir clash in notifier

Reviewed-by: zsong

-------------

PR: https://git.openjdk.org/skara/pull/1700


More information about the skara-dev mailing list