RFR: 1357: Add Oracle copyright header format check to jcheck [v2]

[Magnus Ihse Bursie]

On Thu, 5 Dec 2024 23:50:21 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightConfiguration.java line 29:
>> 
>>> 27: public class CopyrightConfiguration {
>>> 28:     static final CopyrightConfiguration DEFAULT =
>>> 29:             new CopyrightConfiguration(".*\\.cpp|.*\\.hpp|.*\\.c|.*\\.h|.*\\.java");
>> 
>> I would like to see more filetypes included by default. At least `Makefile`, `*.gmk`, `configure`, `*.m4`, `*.md` and `*.properties`. Probably also `*.cc`, `*.hh` and `*.m`.
>> 
>> We could also consider not defining defaults here and have it all in .jcheck/conf for better visibility.
>
> Ah, I didn't think about the default filetypes, just copied from the default of whitespaceConfiguration. I was thinking we can configure it in .jcheck/conf later like the configuration for  whitespace check https://github.com/openjdk/jdk/blob/41c8971cbcc1d281ffae907c952637ebff945ebb/.jcheck/conf#L19

I definitely agree that file patterns that should be checked should be defined in .jcheck/conf.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1872822578