RFR: 2169 pr-bot should ignore case in "Backport <sha>" PR titles [v3]
Erik Joelsson
erikj at openjdk.org
Tue Feb 13 18:46:52 UTC 2024
On Tue, 13 Feb 2024 11:29:15 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:
>> There's no reason why this should validate case, and has caused unnecessary friction in the past.
>
> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>
> Tests
Marked as reviewed by erikj (Lead).
bots/pr/src/test/java/org/openjdk/skara/bots/pr/BackportTests.java line 1187:
> 1185: var editHash = localRepo.commit("Backport", "duke", "duke at openjdk.org");
> 1186: localRepo.push(editHash, author.authenticatedUrl(), "refs/heads/edit", true);
> 1187: var pr = credentials.createPullRequest(author, "master", "edit", "bacKporT" + releaseHash.hex());
I hadn't realized this, but we actually don't require space between `backport` and the hash. That's probably fine and not something we need to change here.
-------------
PR Review: https://git.openjdk.org/skara/pull/1611#pullrequestreview-1878689272
PR Review Comment: https://git.openjdk.org/skara/pull/1611#discussion_r1488407041
More information about the skara-dev
mailing list