RFR: 2169 pr-bot should ignore case in "Backport <sha>" PR titles [v3]

Ludvig Janiuk lujaniuk at openjdk.org
Wed Feb 14 08:49:28 UTC 2024


On Tue, 13 Feb 2024 18:42:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tests
>
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/BackportTests.java line 1187:
> 
>> 1185:             var editHash = localRepo.commit("Backport", "duke", "duke at openjdk.org");
>> 1186:             localRepo.push(editHash, author.authenticatedUrl(), "refs/heads/edit", true);
>> 1187:             var pr = credentials.createPullRequest(author, "master", "edit", "bacKporT" + releaseHash.hex());
> 
> I hadn't realized this, but we actually don't require space between `backport` and the hash. That's probably fine and not something we need to change here.

Yep

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1611#discussion_r1489113128


More information about the skara-dev mailing list