RFR: 2149: Allow multiple query parameters with the same key
Erik Duveblad
ehelin at openjdk.org
Fri Jan 19 09:55:34 UTC 2024
On Thu, 18 Jan 2024 18:49:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Hi all.
>>
>> please review this patch that makes `RestRequest` support multiple query parameters with the same key. This idiom is sometimes used in REST APIs (for example GitLab's REST API). The query parameters should always be kept in program order, since some REST APIs (e.g. GitLab) care about the order of the query parameters.
>>
>> I also added a new `build` method on `RestRequest` to ease unit testing.
>>
>> ### Testing
>> - [x] Added a bunch of unit tests
>
> Marked as reviewed by erikj (Lead).
Thanks @erikj79 and @zhaosongzs for reviewing!
-------------
PR Comment: https://git.openjdk.org/skara/pull/1601#issuecomment-1900089055
More information about the skara-dev
mailing list