RFR: 2149: Allow multiple query parameters with the same key

Zhao Song zsong at openjdk.org
Thu Jan 18 22:50:32 UTC 2024


On Thu, 18 Jan 2024 09:19:32 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all.
> 
> please review this patch that makes `RestRequest` support multiple query parameters with the same key. This idiom is sometimes used in REST APIs (for example GitLab's REST API). The query parameters should always be kept in program order, since some REST APIs (e.g. GitLab) care about the order of the query parameters.
> 
> I also added a new `build` method on `RestRequest` to ease unit testing.
> 
> ### Testing
> - [x] Added a bunch of unit tests

LGTM

-------------

Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1601#pullrequestreview-1830681373


More information about the skara-dev mailing list