Integrated: 2149: Allow multiple query parameters with the same key

Erik Duveblad ehelin at openjdk.org
Fri Jan 19 09:55:35 UTC 2024


On Thu, 18 Jan 2024 09:19:32 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all.
> 
> please review this patch that makes `RestRequest` support multiple query parameters with the same key. This idiom is sometimes used in REST APIs (for example GitLab's REST API). The query parameters should always be kept in program order, since some REST APIs (e.g. GitLab) care about the order of the query parameters.
> 
> I also added a new `build` method on `RestRequest` to ease unit testing.
> 
> ### Testing
> - [x] Added a bunch of unit tests

This pull request has now been integrated.

Changeset: 778b09b1
Author:    Erik Duveblad <ehelin at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/778b09b1adddf19de26caf40c82225d10b3b4c35
Stats:     88 lines in 6 files changed: 76 ins; 1 del; 11 mod

2149: Allow multiple query parameters with the same key

Reviewed-by: erikj, zsong

-------------

PR: https://git.openjdk.org/skara/pull/1601


More information about the skara-dev mailing list