Integrated: 2152: Use full name for tags if possible

Erik Duveblad ehelin at openjdk.org
Mon Jan 22 08:57:57 UTC 2024


On Fri, 19 Jan 2024 10:24:14 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes the `/tag` commit command use the user's full name (if possible) for the author and committer name field for the Git tag it creates. This is the same convention we use for the author/committer name and e-mail metadata in the commits (it was just a mistake on my part that `contributor.username()` was used in the original code for the `/tag` commit command).
> 
> ### Testing
> - [x] Added a new unit tests that fails without this patch but passes with it
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 63018e97
Author:    Erik Duveblad <ehelin at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/63018e97b0e72d78a52fdcfad98ee7fb0c28a38d
Stats:     52 lines in 2 files changed: 51 ins; 0 del; 1 mod

2152: Use full name for tags if possible

Reviewed-by: erikj, zsong

-------------

PR: https://git.openjdk.org/skara/pull/1603


More information about the skara-dev mailing list