RFR: 2164: Add git notes notifier

[Erik Joelsson]

On Mon, 29 Jan 2024 14:35:37 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds a new notifier that records the link to a commit, the link to the review and ev. links to issues in a [git note](https://git-scm.com/docs/git-notes). This will make it possible to view this information using e.g. `git log` or `git show` _without_ having these URLs in the commit message itself. Git notes are also modifiable (they are just blobs referred to by a ref), so they can be updated if ever change the scheme or domain for these links.
> 
> I also added two unit tests for testing the new notifier.
> 
> Thanks,
> Erik

Could you add one of these to a test in NotifierBotFactoryTest? It's not complicated, but I like have example configurations in those tests as they also kind of serve as documentation.

forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java line 587:

> 585:         var url = URI.create(o.get("html_url").asString());
> 586:         var webUrl = gitHubHost.getWebURI(url.getPath());
> 587:         return Optional.of(new HostedCommit(metadata, diffs, url, webUrl));

Should we provide an implementation for GitLab as well?

-------------

PR Review: https://git.openjdk.org/skara/pull/1608#pullrequestreview-1848897451
PR Review Comment: https://git.openjdk.org/skara/pull/1608#discussion_r1469727437