RFR: 2164: Add git notes notifier

[Erik Duveblad]

On Mon, 29 Jan 2024 15:05:36 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Could you add one of these to a test in NotifierBotFactoryTest? It's not complicated, but I like have example configurations in those tests as they also kind of serve as documentation.

Sure, will do!

> forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java line 587:
> 
>> 585:         var url = URI.create(o.get("html_url").asString());
>> 586:         var webUrl = gitHubHost.getWebURI(url.getPath());
>> 587:         return Optional.of(new HostedCommit(metadata, diffs, url, webUrl));
> 
> Should we provide an implementation for GitLab as well?

No I don't think so as we currently don't have a need to rewrite any GitLab URLs. We rewrite `github.com` to `git.openjdk.org` so that links stored in OpenJDK infrastructure (like JBS, mailing lists, etc.) aren't tried to GitHub (if we ever change forge then we can implement a re-direct service). For GitLab we currently don't have that need.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1608#issuecomment-1917090262
PR Review Comment: https://git.openjdk.org/skara/pull/1608#discussion_r1471392150