RFR: 2331: Improve review notes
Pavel Rappo
prappo at openjdk.org
Thu Jul 18 10:57:03 UTC 2024
There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
- 🔄 Re-review required ...
- ⚠️ Review applies to ...
That note may confuse or draw unneeded attention to the PR body.
Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
[SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312
-------------
Commit messages:
- Don't add "Re-review required" if reviewed
- Don't add "Review applies to" to the head of a PR
Changes: https://git.openjdk.org/skara/pull/1679/files
Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1679&range=00
Issue: https://bugs.openjdk.org/browse/SKARA-2331
Stats: 31 lines in 3 files changed: 18 ins; 0 del; 13 mod
Patch: https://git.openjdk.org/skara/pull/1679.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1679/head:pull/1679
PR: https://git.openjdk.org/skara/pull/1679
More information about the skara-dev
mailing list