RFR: 2331: Improve review notes

Thu Jul 18 13:29:28 UTC 2024

On Thu, 18 Jul 2024 12:46:32 GMT, Chen Liang <liach at openjdk.org> wrote:

> Can we change the emoji for "outdated review" from ⚠️ to something weaker than 🔄, like 🕒?

The "⚠️" icon indicates that a particular review is stale: that is, the review applies to a commit which is no longer the HEAD of the PR. Although it draws attention, this indication does not necessitate any action. Such a review still counts: it is legitimate in every way.

The "🔄" icon also indicates that a particular review is stale. However, unlike the previous type, such a review is restricted. While the reviewer will be mentioned in the "Reviewed-by" list of the commit message, currently the review is not counted towards the minimum number of reviews and, thus, does not help to get the PR closer to "ready".

In my opinion, the only circumstance where "🔄" seems too "strong" of an indication is when a PR is "ready". This happens when there are more reviews than required, but some of the extra ones are stale.

This PR addresses that issue. Does it also address your issue?

-------------

PR Comment: https://git.openjdk.org/skara/pull/1679#issuecomment-2236523525