RFR: 2331: Improve review notes [v2]

[Zhao Song]

On Tue, 23 Jul 2024 09:33:14 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
>> 
>>   - 🔄 Re-review required ...
>>   - ⚠️ Review applies to ...
>> 
>> That note may confuse or draw unneeded attention to the PR body.
>> 
>> Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
>> 
>> [SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312
>
> Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Avoid emojis and "required" when a PR is ready
>  - Re-indent code

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 608:

> 606:                         if (useStaleReviews || tooFewReviewers) {
> 607:                             entry += " 🔄 Re-review required (review was made when pull request targeted the [" + review.targetRef()
> 608:                                     + "](" + pr.repository().webUrl(new Branch(review.targetRef())) + ") branch)";

Why should we always display  "🔄" when `useStaleReviews==true`?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1679#discussion_r1688398396