Integrated: 2277: Integer Overflow when parsing GitHub comment id

Zhao Song zsong at openjdk.org
Tue Jun 4 15:58:23 UTC 2024


On Tue, 4 Jun 2024 15:27:44 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When parsing the comment id from Github, skara bot would convert the JSONValue to integer, then convert integer to string and now this is causing integer overflow.
> 
> I thought we should just convert it from JSONValue to String.
> But Erik pointed out this won't work. We should convert it to long and convert long to string

This pull request has now been integrated.

Changeset: 963e380a
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/963e380a1297072aa94d7b09e0b58accf20a36e9
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

2277: Integer Overflow when parsing GitHub comment id

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1655


More information about the skara-dev mailing list