Integrated: 2277: Integer Overflow when parsing GitHub comment id
Erik Joelsson
erikj at openjdk.org
Tue Jun 4 15:58:23 UTC 2024
On Tue, 4 Jun 2024 15:27:44 GMT, Zhao Song <zsong at openjdk.org> wrote:
> When parsing the comment id from Github, skara bot would convert the JSONValue to integer, then convert integer to string and now this is causing integer overflow.
>
> I thought we should just convert it from JSONValue to String.
> But Erik pointed out this won't work. We should convert it to long and convert long to string
Marked as reviewed by erikj (Lead).
I don't think this will work. JSONNumber.asString() throws exception.
Marked as reviewed by erikj (Lead).
-------------
PR Review: https://git.openjdk.org/skara/pull/1655#pullrequestreview-2096773355
Changes requested by erikj (Lead).
PR Review: https://git.openjdk.org/skara/pull/1655#pullrequestreview-2096782165
PR Review: https://git.openjdk.org/skara/pull/1655#pullrequestreview-2096817498
More information about the skara-dev
mailing list