RFR: 2278: Issuestitle Check shouldn't treat special character as leading lowercase letter [v2]

[Erik Joelsson]

On Tue, 4 Jun 2024 18:47:48 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, in IssuesTitleCheck::hasLeadingLowercaseLetter, the method checks if the leading character is uppercase, if so, it returns false. Otherwise, it will treat the character as lowercase. This is wrong because it treats special characters as lowercase letters. The solution is to make the method to check if the leading character is a lowercase letter.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 91:

> 89: 
> 90:     private boolean hasLeadingLowerCaseLetter(String description) {
> 91:         return ALL_LOWER_CASE_PATTERN.matcher(description.split(" ")[0]).matches();

This could all be captured in the regex instead of splitting the string first. Something like `"[a-z]+(:?\\h.*)?"` should do it I think.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1656#discussion_r1626517594