RFR: 2278: Issuestitle Check shouldn't treat special character as leading lowercase letter [v2]
Kevin Rushforth
kcr at openjdk.org
Tue Jun 4 20:12:15 UTC 2024
On Tue, 4 Jun 2024 19:38:12 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update
>
> jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 91:
>
>> 89:
>> 90: private boolean hasLeadingLowerCaseLetter(String description) {
>> 91: return ALL_LOWER_CASE_PATTERN.matcher(description.split(" ")[0]).matches();
>
> This could all be captured in the regex instead of splitting the string first. Something like `"[a-z]+(:?\\h.*)?"` should do it I think.
Is the `:?` needed? It seems redundant, but I'm not a regex expert.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1656#discussion_r1626549953
More information about the skara-dev
mailing list