RFR: 2278: Issuestitle Check shouldn't treat special character as leading lowercase letter [v2]

Zhao Song zsong at openjdk.org
Tue Jun 4 20:20:56 UTC 2024


On Tue, 4 Jun 2024 20:10:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 91:
>> 
>>> 89: 
>>> 90:     private boolean hasLeadingLowerCaseLetter(String description) {
>>> 91:         return ALL_LOWER_CASE_PATTERN.matcher(description.split(" ")[0]).matches();
>> 
>> This could all be captured in the regex instead of splitting the string first. Something like `"[a-z]+(:?\\h.*)?"` should do it I think.
>
> Is the `:?` needed? It seems redundant, but I'm not a regex expert.

I think Erik has a typo here, should be `"[a-z]+(?:\\h.*)?"`?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1656#discussion_r1626555807


More information about the skara-dev mailing list