RFR: 2286: Git jcheck --working-tree/--staged not compatible with some checks [v3]

Erik Joelsson erikj at openjdk.org
Fri Jun 7 21:09:51 UTC 2024


On Fri, 7 Jun 2024 20:31:33 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-1690](https://bugs.openjdk.org/browse/SKARA-1690), I tried to make SKARA CLI able to run jcheck on the diff in current working tree. But seems like this feature is not compatible with some jchecks like problemLists check.
>> 
>> When jcheck is checking staged or working-tree, I think there is no point to run some checks that require real commit message. Therefore I disabled the checks and Skara CLI will print a prompt to user.
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
>    
>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>  - Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
>    
>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1658#pullrequestreview-2105372400


More information about the skara-dev mailing list