RFR: 2286: Git jcheck --working-tree/--staged not compatible with some checks [v3]

Zhao Song zsong at openjdk.org
Fri Jun 7 20:31:33 UTC 2024


> In [SKARA-1690](https://bugs.openjdk.org/browse/SKARA-1690), I tried to make SKARA CLI able to run jcheck on the diff in current working tree. But seems like this feature is not compatible with some jchecks like problemLists check.
> 
> When jcheck is checking staged or working-tree, I think there is no point to run some checks that require real commit message. Therefore I disabled the checks and Skara CLI will print a prompt to user.

Zhao Song has updated the pull request incrementally with two additional commits since the last revision:

 - Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
   
   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
 - Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
   
   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1658/files
  - new: https://git.openjdk.org/skara/pull/1658/files/da514368..169e2157

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1658&range=02
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1658&range=01-02

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1658.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1658/head:pull/1658

PR: https://git.openjdk.org/skara/pull/1658


More information about the skara-dev mailing list