RFR: 2307: PullRequestCheckIssueVisitor generates only one error message per Issue type

[Erik Joelsson]

On Mon, 24 Jun 2024 22:31:58 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When testing [SKARA-2303](https://bugs.openjdk.org/browse/SKARA-2303), I found that even when there are few binary files in a diff, the pr body only warns about one binary file. Then I found that in PullRequestCheckIssueVisitor, we are using HashMap<Check, String> to store the error messages, so if there are few issues with the same type, the HashMap is only able to save the last error message.

I wonder if this was done on purpose to limit the number of issues listed. 

Is there a limitation on the number of errors shown in the presentation layer? 

Do all checks produce unique messages (like which file has the problem) for each instance? If not, then having multiple instances with the same message isn't going to be very helpful.

-------------

PR Review: https://git.openjdk.org/skara/pull/1662#pullrequestreview-2137550610