RFR: 2307: PullRequestCheckIssueVisitor generates only one error message per Issue type

Zhao Song zsong at openjdk.org
Tue Jun 25 16:47:37 UTC 2024


On Tue, 25 Jun 2024 07:03:13 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I wonder if this was done on purpose to limit the number of issues listed.

Maybe not intended since this behavior is only in PullRequestCheckIssueVisitor. In JCheckCLIVisitor, it will print all the messages.

> Is there a limitation on the number of errors shown in the presentation layer?

No.

> Do all checks produce unique messages (like which file has the problem) for each instance? If not, then having multiple instances with the same message isn't going to be very helpful.

Yes, all checks will generate unique messages otherwise it will only generate one issue.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1662#issuecomment-2189443593


More information about the skara-dev mailing list