RFR: 2307: PullRequestCheckIssueVisitor generates only one error message per Issue type [v2]
Zhao Song
zsong at openjdk.org
Wed Jun 26 18:45:00 UTC 2024
On Tue, 25 Jun 2024 22:16:35 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> When testing [SKARA-2303](https://bugs.openjdk.org/browse/SKARA-2303), I found that even when there are few binary files in a diff, the pr body only warns about one binary file. Then I found that in PullRequestCheckIssueVisitor, we are using HashMap<Check, String> to store the error messages, so if there are few issues with the same type, the HashMap is only able to save the last error message.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> set limit for error messages
Thanks for the review!
-------------
PR Comment: https://git.openjdk.org/skara/pull/1662#issuecomment-2192406202
More information about the skara-dev
mailing list