Integrated: 2307: PullRequestCheckIssueVisitor generates only one error message per Issue type

Zhao Song zsong at openjdk.org
Wed Jun 26 18:45:00 UTC 2024


On Mon, 24 Jun 2024 22:31:58 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When testing [SKARA-2303](https://bugs.openjdk.org/browse/SKARA-2303), I found that even when there are few binary files in a diff, the pr body only warns about one binary file. Then I found that in PullRequestCheckIssueVisitor, we are using HashMap<Check, String> to store the error messages, so if there are few issues with the same type, the HashMap is only able to save the last error message.

This pull request has now been integrated.

Changeset: 0a81cd1b
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/0a81cd1b3214c691dba47c2079e9f33556cca2d5
Stats:     36 lines in 3 files changed: 14 ins; 0 del; 22 mod

2307: PullRequestCheckIssueVisitor generates only one error message per Issue type

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1662


More information about the skara-dev mailing list