RFR: 2070: Get a placeholder message spot for integration message

[Erik Joelsson]

On Fri, 8 Mar 2024 23:48:04 GMT, Zhao Song <zsong at openjdk.org> wrote:

> As Magnus said in the issue description, sometimes it's hard for users to find the merge ready comment. So he would like to see that this message is added as soon as possible, after the bridgekeeper has done its job. 
> 
> In this patch, on the very beginning of CheckWorkItem, skara bot would post a placeholder message to the PR and update it later.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 728:

> 726:     }
> 727: 
> 728:     private List<Comment> postPlaceholderMessageForReadyComment(List<Comment> comments) {

I think this method name would be both shorter and clearer:

Suggestion:

    private List<Comment> postPlaceholderForReadyComment(List<Comment> comments) {

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 738:

> 736:         String message = "❗ This change is not yet ready to be integrated.\n" +
> 737:                 "See the **Progress** checklist in the description for automated requirements.\n" +
> 738:                 "This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.\n" +

This message in `getMergeReadyComment` is only printed if the file exists in the repo. It's not included in `getMergeNoLongerReadyComment`. Not sure if it's worth including here. I think we should probably just emulate the no longer ready comment as closely as possible.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1619#discussion_r1520235766
PR Review Comment: https://git.openjdk.org/skara/pull/1619#discussion_r1520251237