RFR: 2070: Get a placeholder message spot for integration message [v2]

Zhao Song zsong at openjdk.org
Mon Mar 11 20:13:32 UTC 2024


On Mon, 11 Mar 2024 18:30:15 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
>>   
>>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 738:
> 
>> 736:         String message = "❗ This change is not yet ready to be integrated.\n" +
>> 737:                 "See the **Progress** checklist in the description for automated requirements.\n" +
>> 738:                 "This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.\n" +
> 
> This message in `getMergeReadyComment` is only printed if the file exists in the repo. It's not included in `getMergeNoLongerReadyComment`. Not sure if it's worth including here. I think we should probably just emulate the no longer ready comment as closely as possible.

Yes, we shouldn't include that message. I will fix it. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1619#discussion_r1520371728


More information about the skara-dev mailing list