RFR: 2198: Backport PRs should check if a CSR is required [v2]

[Zhao Song]

On Thu, 21 Mar 2024 19:51:57 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make CSR process link a constant
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1566:
> 
>> 1564:                     .filter(Optional::isPresent)
>> 1565:                     .map(Optional::get)
>> 1566:                     .map(Backports::csrLink)
> 
> I'm a bit concerned that we will be going through csrLinks twice, first to see if there are any associated CSRs and then here to see if there are any resolved ones. Not sure if there is a feasible way to either combine the checks or cache the results between them.

I tried, but the code right now seems a bit complicated.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1623#discussion_r1534885222