RFR: 2198: Backport PRs should check if a CSR is required [v2]

[Erik Joelsson]

On Fri, 22 Mar 2024 00:18:05 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1566:
>> 
>>> 1564:                     .filter(Optional::isPresent)
>>> 1565:                     .map(Optional::get)
>>> 1566:                     .map(Backports::csrLink)
>> 
>> I'm a bit concerned that we will be going through csrLinks twice, first to see if there are any associated CSRs and then here to see if there are any resolved ones. Not sure if there is a feasible way to either combine the checks or cache the results between them.
>
> I tried, but the code right now seems a bit complicated.

I think it's fine. Maybe it would help with a comment on each method explaining what exactly it's constructing.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1623#discussion_r1535676127