RFR: 2272: Improve issuestitleCheck

Zhao Song zsong at openjdk.org
Fri May 31 20:33:51 UTC 2024


On Fri, 31 May 2024 20:05:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> IssuestitleCheck was enabled in jdk recently, but this seems triggers too many false positive warnings and makes people feel annoying.
>> 
>> In this patch, I am trying to make the issuestitle check more tolerant. For some known cases, issuestitle check wouldn't generate issues.
>
> jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 38:
> 
>> 36:     private final Logger log = Logger.getLogger("org.openjdk.skara.jcheck.issuesTitle");
>> 37:     private final static List<String> VALID_WORD_WITH_TRAILING_PERIOD = List.of("et al.", "etc.", "...");
>> 38:     private final static List<String> EXECUTABLE_NAMES = List.of("javac", "dpkg");
> 
> This list would potentially get very long. I'm not sure it's worth trying to maintain one. The other patterns seem ok to me.

I was thinking we should ask if David Holmes has any thoughts about this list...

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1622925753


More information about the skara-dev mailing list