RFR: 2272: Improve issuestitleCheck [v2]

[Erik Joelsson]

On Fri, 31 May 2024 20:31:39 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 38:
>> 
>>> 36:     private final Logger log = Logger.getLogger("org.openjdk.skara.jcheck.issuesTitle");
>>> 37:     private final static List<String> VALID_WORD_WITH_TRAILING_PERIOD = List.of("et al.", "etc.", "...");
>>> 38:     private final static List<String> EXECUTABLE_NAMES = List.of("javac", "dpkg");
>> 
>> This list would potentially get very long. I'm not sure it's worth trying to maintain one. The other patterns seem ok to me.
>
> I was thinking we should ask if David Holmes has any thoughts about this list...

No I think it should just be removed. Otherwise we will end up having to list every executable in the JDK as well as basically every build tool used when building it, and even so, that would be a very JDK project specific list of executables. Several of those would also overlap with words that we would want to flag, e.g. "make", "java".

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1623038258