RFR: 2410: Introduce process killing finally block in GitCommits

[Zhao Song]

On Tue, 19 Nov 2024 23:39:04 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> vcs/src/main/java/org/openjdk/skara/vcs/git/GitCommits.java line 170:
>> 
>>> 168:             throw new IOException("'" + String.join(" ", command) + "' was interrupted", e);
>>> 169:         } finally {
>>> 170:             if (p.isAlive()) {
>> 
>> For the record, this might be insufficient because `GitCommits` might have created multiple processes and this destroys only one of them.
>> 
>> In general, Skara needs better tools to deal with processes.
>
> Oh, you are right. I didn't look at the whole class.

Do you mean we need to iterate all the processes and destroy them in the finally block?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1697#discussion_r1849306154