RFR: 2410: Introduce process killing finally block in GitCommits

[Erik Joelsson]

On Tue, 19 Nov 2024 23:42:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Oh, you are right. I didn't look at the whole class.
>
> Do you mean we need to iterate all the processes and destroy them in the finally block?

I think the loop needs to make sure the inner close method is called on each process by catching exceptions and saving one of them, probably the first one, and then rethrow it once all processes have been dealt with. In practice I doubt there will ever be multiple processes though. That would only happen if `::iterator` is called multiple times.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1697#discussion_r1850333202