RFR: 2415: Update GitCommits::close to make sure it terminates all processes when an exception is thrown [v2]

[Pavel Rappo]

On Thu, 21 Nov 2024 22:03:41 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> As Pavel pointed out in the pull request of [SKARA-2410](https://bugs.openjdk.org/browse/SKARA-2410)(https://github.com/openjdk/skara/pull/1697), with current implementation , GitCommits::close may have created multiple processes and only destroy one of them.
>> 
>> As Erik and Pavel suggested, we should make sure close() is called on each process.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

vcs/src/main/java/org/openjdk/skara/vcs/git/GitCommits.java line 145:

> 143:             try {
> 144:                 close(p, command);
> 145:             } catch (IOException | RuntimeException e) {

What kind of runtime exception are you expecting here?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1699#discussion_r1853813660