RFR: 2415: Update GitCommits::close to make sure it terminates all processes when an exception is thrown [v2]

[Erik Joelsson]

On Fri, 22 Nov 2024 12:04:36 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment
>
> vcs/src/main/java/org/openjdk/skara/vcs/git/GitCommits.java line 145:
> 
>> 143:             try {
>> 144:                 close(p, command);
>> 145:             } catch (IOException | RuntimeException e) {
> 
> What kind of runtime exception are you expecting here?

I suggested catching it mostly to be defensive. The Skara code base uses RuntimeExceptions quite a lot. In this case, there is no obvious place where one would be thrown though

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1699#discussion_r1853959016