RFR: 2415: Update GitCommits::close to make sure it terminates all processes when an exception is thrown [v2]
Pavel Rappo
prappo at openjdk.org
Fri Nov 22 19:29:24 UTC 2024
On Fri, 22 Nov 2024 18:25:26 GMT, Zhao Song <zsong at openjdk.org> wrote:
>>> I suggested catching it mostly to be defensive. The Skara code base uses RuntimeExceptions quite a lot. In this case, there is no obvious place where one would be thrown though
>>
>> I've had a look at those; I see what you mean.
>>
>> A separate nit for later is calling those exceptions _errors_; this is not conventional in Java:
>>
>> class GitHubApplicationError extends RuntimeException
>>
>> "Error" strongly suggests a subclass of `java.lang.Error`. If you need some other word, but "Exception" is undesirable, you may want to call it "Failure".
>
> I think we can improve it later, but not in this pr.
I see you have already integrated the PR; okay.
Erik, I couldn't see where those Skara-specific runtime exceptions could be thrown from in this particular case, but maybe you see it as some sort of future proofing?
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1699#discussion_r1854545624
More information about the skara-dev
mailing list