RFR: 2415: Update GitCommits::close to make sure it terminates all processes when an exception is thrown [v2]

[Erik Joelsson]

On Fri, 22 Nov 2024 19:27:04 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> I think we can improve it later, but not in this pr.
>
> I see you have already integrated the PR; okay.
> 
> Erik, I couldn't see where those Skara-specific runtime exceptions could be thrown from in this particular case, but maybe you see it as some sort of future proofing?

> Erik, I couldn't see where those Skara-specific runtime exceptions could be thrown from in this particular case, but maybe you see it as some sort of future proofing?

> In this case, there is no obvious place where one would be thrown though

I meant that there is no explicit throwing of RuntimeException in this code, but if we would ever get an NPE or similar, I think we should still make sure all processes are killed.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1699#discussion_r1854773270