RFR: 2373: Support repo-<project> style fix versions

Zhao Song zsong at openjdk.org
Tue Sep 17 23:55:00 UTC 2024


On Tue, 17 Sep 2024 23:04:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch adds parsing logic for handling version strings on the form "repo-<project>". This form is commonly used in JBS for project repos, but Skara is currently unable to actually parse them.

Looks good

jbs/src/main/java/org/openjdk/skara/jbs/JdkVersion.java line 82:

> 80:         // Check for team/project special version
> 81:         if (finalComponents.isEmpty()) {
> 82:             var projectRepoPattern = Pattern.compile("repo-([a-z0-9]*)");

For consistency with the surrounding code, would it be better to define this pattern as a static variable?

-------------

Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1686#pullrequestreview-2311358982
PR Review Comment: https://git.openjdk.org/skara/pull/1686#discussion_r1764219796


More information about the skara-dev mailing list